[Webkit-unassigned] [Bug 42367] Speech input plumbing in webkit

Fri Jul 16 08:31:16 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42367

Satish Sampath <satish at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61809|                            |review?
               Flag|                            |

--- Comment #6 from Satish Sampath <satish at chromium.org>  2010-07-16 08:31:15 PST ---
Created an attachment (id=61809)
 --> (https://bugs.webkit.org/attachment.cgi?id=61809)
Patch

Addressed all of Marcus's comments, except changing the name of SpeechInputClientImpl to WebSpeechInputClientImpl. It looks to me that the 'Web' prefix is used primarily for interfaces/classes exposed from WebKit via the headers in chromium/public directory. Majority of classes in chromium/src doesn't have the 'Web' prefix and most of those which do have the prefix are implementations of classes exposed in the chromium/public directory. I'm happy to change the name if my understanding is incorrect and there is a strong reason to have the 'Web' prefix even for classes internal to WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.