[Webkit-unassigned] [Bug 39589] Add LayoutTestController methods to test DeviceOrientation

Fri Jul 16 07:16:18 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39589

--- Comment #7 from Satish Sampath <satish at chromium.org>  2010-07-16 07:16:18 PST ---
Not a review, just a drive-by comment:

> This former approach isn't scalable. The latter is, and by removing the DeviceOrientationClient argument from the Page constructor, avoids the scalability problem there too. Note that this approach was taken for the SpeechInputClient in Bug 41518.
> 
> I think it's probably best to make the change to add Page.setDeviceOrientationClient. What do you think?

Yes this was the reason I chose a setter for the client pointer in the speech input patch. The Page constructor is quite overloaded with 9 parameters now and many of them are used in only few of the ports. A setter would clean it up, while allowing the webkit layer to switch to the mock when necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.