[Webkit-unassigned] [Bug 41201] CSS3 background: Number of layers should be determined by background-image element count

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 16 05:50:27 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41201





--- Comment #8 from Andreas Kling <andreas.kling at nokia.com>  2010-07-16 05:50:26 PST ---
We need to fillUnsetProperties() before we cullEmptyLayers()

Consider the following scenario:

#foo {
    background-image: url('Layer1'), ('Layer2');
    background-repeat: no-repeat;
}

The previous version of the patch would discard Layer2 since it had no corresponding properties. If we instead fillUnsetProperties() first, we get the correct result:

#foo {
    background-image: url('Layer1'), ('Layer2');
    background-repeat: no-repeat, no-repeat;
}

Now for the reverse scenario:

#foo {
    background-image: url('Layer1');
    background-repeat: no-repeat, no-repeat;
}

cullEmptyLayers() would previously remove the second 'no-repeat' before fillUnsetProperties() had a chance to repeat Layer1. If we swap the order of fillUnsetProperties() and cullEmptyLayers() we need to alter fillUnsetProperties() a bit - it shouldn't repeat image properties.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list