[Webkit-unassigned] [Bug 42273] Convolution computation causes bad alpha channel values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42273





--- Comment #32 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-16 02:31:36 PST ---
Issue 1:
float* totals is passed from fastSetInteriorPixels, and the new helper function setDestinationPixels is called multiple times. That means you're doing the divisior division multiple times, accumulated!

for (int i = 0; i < numTotals; ++i)
    totals[i] = totals[i] / divisor + bias;

Issue 2:
for (int i = 0; i < 3; ++i)
    image->set(pixel++, clampRGBAValue(totals[0], maxAlpha));

You're always clamping totals[0], not totals[i].

Very evil!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.