[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898





--- Comment #17 from Mario Sanchez Prada <msanchez at igalia.com>  2010-07-16 01:56:57 PST ---
(In reply to comment #14)
> [...]
> 
> If sending out a ValueChange notification alone is not sufficient, I recommend 
> putting
> 
> void AppendNodeCommand::notifyAccessibility(bool isUndo)
> 
> inside of AXObjectCache
> 
> then having the GTK specific code live in either AXObjectCacheGTK or 
> AccessibilityObjectGTK

Thanks for the clarification, Chris. As you can see I've attached two new patches replacing the old 2-5 patches (1st patch would be still valid as it is), hopefully properly addressing your suggestion of centralizing code in AXObjectCache and AXObjectCacheGtk.

I've tried this new way of doign things out and it works exactly the same, passing both the API and Layout tests as well, at least in the gtk build (I couldn't try to compile for other ports but the dummy implementation of nodeTextChangePlatformNotification for win and mac shouldn't be an issue)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.