[Webkit-unassigned] [Bug 42042] An empty value for xml:lang isn't considered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42042


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rwlbuis at gmail.com




--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2010-07-15 22:44:43 PST ---
Hi Mitz,

(In reply to comment #3)
> (From update of attachment 61706 [details])
> > -                if (value.isEmpty() || !value.startsWith(argument, false))
> > +                if (value.isNull() || !value.startsWith(argument, false))
> 
> Why is this change needed or desirable?

Coming out of the loop, value.isEmpty() now means an acceptable value where we can test
the :lang selector against, and value.isNull() means no lang value found, so we can break.
Cheers,

Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.