[Webkit-unassigned] [Bug 42244] SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 06:25:47 PDT 2010


--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-15 06:25:47 PST ---
(In reply to comment #1)
> Can I use this as a template for other elements?
> void SVGClipPathElement::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)
> {
>     SVGStyledTransformableElement::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
>     if (!changedByParser)
>         invalidateResourceClients();
> }

Yes you can, you just have to invalidate the parent filter, as the effects themselves don't have renderers.

> Why all base classes are tested? Isn't it should be done by SVGStyledTransformableElement::svgAttributeChanged? Do I need to check all base classes?

Only SVGFooElement inherits from SVGTests/SVGURIRef, etc.. not SVGStyledTRanformableElement itself, so you have to do the check there.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list