[Webkit-unassigned] [Bug 42273] Convolution computation causes bad alpha channel values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42273





--- Comment #14 from Zoltan Herczeg <zherczeg at webkit.org>  2010-07-15 00:20:37 PST ---
(In reply to comment #11)
> Adding the original author of our feConvoloveMatrix implementation.

Thanks Dirk.

I like this patch. Just one more thing: wouldn't it be better to add an extra argument to clampRGBAValue, since it actually a min/max function?

So changing: min(min(max(value, 0), 255), alpha) to min(max(value, 0), alpha) ? It would also remove the <math.h> dependency, which is not preferred in WebKit.

clampRGBAValue is inline, so it would not cause slowdown on the unchanged case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.