[Webkit-unassigned] [Bug 33668] WebCore::InsertListCommand::modifyRange infinite loop (100% CPU usage)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33668





--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2010-07-14 17:32:02 PST ---
(In reply to comment #9)
> Created an attachment (id=61587)
 --> (https://bugs.webkit.org/attachment.cgi?id=61587) [details]

Note that the expected result of this patch does NOT match that of MSIE and Firefox.  When intending

<ul>
    <ul><li>hello</li></ul>
    world
    <ol><li>WebKit</li></ol>
</ul>

Both MSIE and Firefox gives

<OL>
    <OL><LI>hello</LI></OL>
    world
    <OL><LI>WebKit</LI></OL>
</OL>

But WebKit gives

<ul>
    <ol><li>hello</li></ol>
</ul>
<ol>
    <li>world</li>
</ol>
<ul>
    <ol><li>WebKit</li></ol>
</ul>

I tried really hard to match new behavior to that of Firefox and MSIE but because we are iterating through multiple paragraphs, we cannot tell whether outer ul can be converted to ol or not when encountering "world". (i.e. if the user selected "world" alone, we should certainly not converting the outer ul to ol).  One approach to solve this problem is to keep the original selection as a range and check whether outer list is contained within the range but this requires more refactoring and fixing, which was not feasible at this point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.