[Webkit-unassigned] [Bug 42292] New: Add PlatformWebFrame to avoid layer violations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42292

           Summary: Add PlatformWebFrame to avoid layer violations
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: Qt
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jesus at webkit.org


In the Qt port we (quite often) need to make use of casts to convert a FrameLoaderClient into a FrameLoaderClientQt in order to get a reference to a QWebFrame.
This can be classified as a layering violation since it's done in WebCore, and can be verified in WebCore/platform/network/qt/ResourceHandleQt.cpp and WebCore/platform/qt/CookieJarQt.cpp for instance.
We use it in order to have synchronous loading correctly implemented for Qt, where the networking backend is bound to the page, despite the support of SSL and proxying in QtWebkit.
r23769 and r29352 can also be used as reference.

Adding FrameLoaderClient::platformWebFrame() would solve this. PlatformWebFrame can be just a typedef for each port.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.