[Webkit-unassigned] [Bug 42278] Removes DontCheckEnums from some IDLs and fixes the corresponding enums.

Wed Jul 14 13:06:14 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42278

Marcus Bulach <bulach at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tonyg at chromium.org

--- Comment #5 from Marcus Bulach <bulach at chromium.org>  2010-07-14 13:06:14 PST ---
(In reply to comment #3)
> (From update of attachment 61550 [details])
> >          enum orientType {
> > -            VERTICAL   = 0,
> > -            HORIZONTAL = 1,
> > +            HORIZONTAL = 0,
> > +            VERTICAL   = 1,
> >              BOTH       = 2
> >          };
> 
> This change seems risky. Was there any C++ code using these constants and thus getting things wrong? Can we construct a test that demonstrates we had them wrong?

yes! added the test, but I'm not sure if it's the best place. let me know if you'd like it to be on a test of its own.

> 
> The rest of the changes seem obviously good.
cool, thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.