[Webkit-unassigned] [Bug 42278] Removes DontCheckEnums from some IDLs and fixes the corresponding enums.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 12:32:48 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=42278





--- Comment #3 from Darin Adler <darin at apple.com>  2010-07-14 12:32:48 PST ---
(From update of attachment 61550)
>          enum orientType {
> -            VERTICAL   = 0,
> -            HORIZONTAL = 1,
> +            HORIZONTAL = 0,
> +            VERTICAL   = 1,
>              BOTH       = 2
>          };

This change seems risky. Was there any C++ code using these constants and thus getting things wrong? Can we construct a test that demonstrates we had them wrong?

The rest of the changes seem obviously good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list