[Webkit-unassigned] [Bug 41295] [Chromium] Add chromium WebMediaPlayer to PlatformMedia

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41295





--- Comment #15 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-07-14 10:54:03 PST ---
(In reply to comment #14)
> Renamed chromiumWebMediaPlayer to chromiumMediaPlayer. Renamed 
> WebMediaElement::getWebMediaPlayer() to player() to match 
> HTMLMediaElement::player().

^^^ good idea


> Is the use of constUnwrap without a #if WEBKIT_IMPLEMENTATION guard okay? It 
> seems it used without the guard at other places, but declaration of constUnwrap 
> is under the guard.

constUnwrap is intended to be used in chromium/src/.  The WEBKIT_IMPLEMENTATION macro is defined when compiling code in chromium/src/.  The code in chromium/public/ however can be compiled with and without WEBKIT_IMPLEMENTATION.  That's why you should only see that macro used in chromium/public/.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.