[Webkit-unassigned] [Bug 42250] Code generator: ensure generated constants match their corresponding enums.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 10:34:39 PDT 2010


--- Comment #14 from Marcus Bulach <bulach at chromium.org>  2010-07-14 10:34:38 PST ---
(In reply to comment #13)
> Why do we need to disable the checking in so many of the existing IDL files? Is it one reason? Multiple reasons? Before we make this the way we do everything in the future, I’d like to understand exactly why our existing code isn’t conformant.

Hi Darin,

There are a few reasons, here's a sample:
1. Node.idl / .h: some of the enums are defined are defined as global constants rather than enums in the .h (DOCUMENT_POSITION_*)

2. DOMCoreException (and a few SVG-related idls): the enum is not defined in the corresponding .h.

3. RangeException.idl / .h: in the header file, the actual constant values are defined in terms of some other value:
BAD_BOUNDARYPOINTS_ERR = RangeExceptionOffset + 1;

4. one other case, OverflowEvent, the values simply don't match.

on 1 and 4, I'm happy to chase this and clean it up, I think it's reasonably straightforward. For (2), I think we'd need to keep the check. For (3), I'm not familiar with those bits, so I'm not sure yet whether or not it's possible to fix.

Please, let me know if this is any clear.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list