[Webkit-unassigned] [Bug 20011] Printing test results differ between machines, we should use ImageDiff instead

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 09:56:49 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=20011


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55528|review?                     |review+
               Flag|                            |




--- Comment #16 from Darin Adler <darin at apple.com>  2010-07-14 09:56:49 PST ---
(From update of attachment 55528)
Seems OK.

WebCore/page/PrintContext.cpp:244
 +              graphicsContext.drawLine(IntPoint(0, currentHeight),
 +                                       IntPoint(pageWidth, currentHeight));
Not our usual formatting. Put it all on one line, or indent by 4 spaces. Please don't indent to match the parenthesis on the line above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list