[Webkit-unassigned] [Bug 42250] Code generator: ensure generated constants match their corresponding enums.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42250





--- Comment #7 from Marcus Bulach <bulach at chromium.org>  2010-07-14 08:36:22 PST ---
(In reply to comment #4)
> (From update of attachment 61507 [details])
> WebCore/bindings/scripts/CodeGeneratorV8.pm:1549
>  +  sub shouldCheckEnum
> We should add a new attribute to these classes in their IDLs rather than adding stuff to the code generator, I think.
> 
> I think I like that we're black listing (rather than white listing) though.  That way people adding constants in the future will need to opt out rather than in.

I'm not entirely convinced it's a property of the interface/idl to decide whether or not to check the generated code: the way I see, the code generator is the bit that knows about the details of the generated code and uses the c++ class, not the idl. Anyways, no strong feelings either way.

I added a new property "DontCheckEnums" and spread across the various interfaces where necessary, and also move the code up to CodeGenerator.pm so that both JS and V8 are now sharing this check. another look please?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.