[Webkit-unassigned] [Bug 41845] refactor identifier parsing in lexer

Wed Jul 14 08:06:16 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=41845

--- Comment #9 from Darin Adler <darin at apple.com>  2010-07-14 08:06:16 PST ---
(From update of attachment 61492)
> +        (JSC::):

You should delete tis line in the ChangeLog, created because of a bug in the prepare-ChangeLog script.

> +    // Character types are divided into two groups depending they can be part of an identifier or not.
> +    // Those, whose type value is less or equal than CharacterNumber, can be part of an identifier.
> +    // (see the CharacterType defintion for more details)

A few small mistakes here. One is "depending they", which should be "depending on whether they". The two commas are not needed or helpful in the second sentence. The sentence in parentheses should have a capital letter and a period.

Patch otherwise looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.