[Webkit-unassigned] [Bug 41682] Certain page elements cause XGetImage and software fallback rendering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41682





--- Comment #5 from Jonathan Morton <jonathan.morton at movial.com>  2010-07-14 07:58:30 PST ---
> On Mac, it always returns true in the check on line 130, and never calls drawPattern.

Okay, that seems to be a difference between the posted testcase and the one we got that diagram from.


> convertes the brush pixmap to an image, see:
> 
> QImage QBrush::textureImage() const
> {
>     return d->style == Qt::TexturePattern
>                      ? (static_cast<QTexturedBrushData *>(d.data()))->image()
>                      : QImage();
> }
> 
> struct QTexturedBrushData : public QBrushData
> {
> ..
>     QImage &image() {
>         if (m_image.isNull() && m_pixmap)
>             m_image = m_pixmap->toImage();
>         return m_image;
>     }
> }
> 
> This is the reason you're seeing the XGetImage calls...

I think this is the key thing - that QImages are being converted to QPixmaps and later back to QImages.

So what would be needed to preserve QImages through the render chain?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.