[Webkit-unassigned] [Bug 42250] Code generator: ensure generated constants match their corresponding enums.

Wed Jul 14 05:23:07 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42250

WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com

--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-07-14 05:23:07 PST ---
Attachment 61507 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1243:  jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1248:  jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1253:  jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1258:  jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1263:  jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.h:178:  jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.h:179:  jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.h:180:  jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.h:181:  jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.h:182:  jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/V8/V8TestObj.cpp:1025:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 11 in 8 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.