[Webkit-unassigned] [Bug 39588] Provide implementation of DeviceOrientationController and hook into DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39588





--- Comment #21 from Jeremy Orlow <jorlow at chromium.org>  2010-07-14 03:05:56 PST ---
(From update of attachment 61370)
WebCore/dom/DeviceOrientationController.cpp:58
 +          m_client->startUpdating();
Shouldn't you just ask the client whether it's been started?  At very least you should probably assert that it's not currently updating.

WebCore/dom/DeviceOrientationController.cpp:52
 +          window->dispatchEvent(DeviceOrientationEvent::create(eventNames().deviceorientationEvent, m_client->lastOrientation()));
Is this specced to be synchronous?  If so, I think we should consider changing it.  If so, you shouldn't do it this way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.