[Webkit-unassigned] [Bug 41423] spelling underline gets lost on backspace

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 01:25:29 PDT 2010


--- Comment #7 from MORITA Hajime <morrita at google.com>  2010-07-14 01:25:29 PST ---
Hi Ojan, thank you for reviewing!
I updated the patch.

> Code looks fine to me except for the comments below. Just needs a test. Not sure it's possible to test spelling markers in DRT. If not, please add a manual test.
Though a pixel test is possible, I prefer inspecting marker from more robust way.
I heard that Bono-san has code for testing marker (for Bug 40092).
I'll ask him if it is available.

> > +    void removeMarkersBeforeMovingParagrah(const VisibleSelection&);
> > +    void markMisspellingsAfterMovingParagrah(const VisibleSelection&);
> I don't like that these names are tied to paragraph moving since the implementations themselves are generic. How about calling them clearMispellingsAndBadGrammer and markMispellingsAndBadGrammer?
Makes sense. renamed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list