[Webkit-unassigned] [Bug 41129] CSSSelector: Avoid chaining tagHistory of CSSSelector, which causes stack overflow.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 00:10:49 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41129





--- Comment #15 from Hayato Ito <hayato at chromium.org>  2010-07-14 00:10:49 PST ---
(In reply to comment #12)
> The chain itself is OK. There's nothing wrong with a linked list.
> 
> What we need to fix this is to add an iterative algorithm for destroying the chain, not to eliminate it entirely. I think I did this already in one of my OwnPtr patches; can’t find it at the moment. We need code that to loops through the list releasing the next pointer before destroying the previous one.

Hi Darin,
Thank you for the comment.

I actually tried to fix it to add an iterative algorithm for destroying the chain in the patch https://bugs.webkit.org/attachment.cgi?id=59764.

To be precise, it's destroying the tree, not the linked list.
Is this a proper way? If so, could you take a look at the patch?
Your OwnPrt patche affects the patch, doesn't it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list