[Webkit-unassigned] [Bug 42228] SVG masks are in the wrong colour space in all non-CG platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42228





--- Comment #11 from Darin Adler <darin at apple.com>  2010-07-13 22:15:05 PST ---
(From update of attachment 61469)
> +#if !PLATFORM(CG)
> +    maskerData->maskImage->transformColorSpace(DeviceRGB, LinearRGB);
> +#endif

It seems mysterious to have a platform ifdef here, even if it's correct. Is there some other way to do this? For example, could there be some kind of feature flag to indicate if this is needed instead of just PLATFORM(CG)? Or perhaps a function that is an inline empty body on CG and implemented on other platforms. The point of the abstractions is to avoid #ifdefs like this in the cross-platform code.

At the very least, there needs to be a comment in the code, not just the change log, explaining why one platform is different from all the others. Even your change log comment states that this is needed "ImageBuffer needs to be explicitly told to convert", without answering the question "why?"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.