[Webkit-unassigned] [Bug 42211] Canvas: rect(x, y, w, h) should move to (x, y) even if w=0 and h=0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42211


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61433|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-07-13 17:18:57 PST ---
(From update of attachment 61433)
Do we still need the validateRectForCanvas function? Can we refactor it so we can still use it?

> +    if (!isfinite(x) | !isfinite(y) | !isfinite(width) | !isfinite(height))
> +        return;

Why "|" instead of "||"?

> +    if (width < 0) {
> +        width = -width;
> +        x -= width;
> +    }
> +
> +    if (height < 0) {
> +        height = -height;
> +        y -= height;
> +    }

It’s inelegant to modify the arguments like this.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.