[Webkit-unassigned] [Bug 41920] Avoid slow-path for put() in Array.splice()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41920


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61424|review?                     |review+
               Flag|                            |




--- Comment #21 from Darin Adler <darin at apple.com>  2010-07-13 15:59:06 PST ---
(From update of attachment 61424)
> -#define CHECK_ARRAY_CONSISTENCY 0

One of the goals for CHECK_ARRAY_CONSISTENCY is to be able to turn it on without recompiling anything except JSArray.cpp. By making m_inCompactInitialization be included in any non-NDEBUG builds, we could achieve that.

The code to set up m_inCompactInitialization and the data member itself would be inside #ifndef NDEBUG rather than #if CHECK_ARRAY_CONSISTENCY.

> +#if CHECK_ARRAY_CONSISTENCY
> +            ASSERT(m_storage->m_inCompactInitialization);
> +#endif

If we used #ifndef NDEBUG we could just unconditionally include this assertion. This gives a good reason to have the boolean there even if CHECK_ARRAY_CONSISTENCY is 0.

r=me as is

Even better if you move CHECK_ARRAY_CONSISTENCY back inside the .cpp file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.