[Webkit-unassigned] [Bug 41423] spelling underline gets lost on backspace

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41423





--- Comment #5 from Ojan Vafai <ojan at chromium.org>  2010-07-13 14:31:39 PST ---
(From update of attachment 61357)
Code looks fine to me except for the comments below. Just needs a test. Not sure it's possible to test spelling markers in DRT. If not, please add a manual test.

> +++ b/WebCore/editing/Editor.h
> +    // Invoked from CompositeEditCommand::moveParagraphs()

This comment doesn't seem especially useful.

> +    void removeMarkersBeforeMovingParagrah(const VisibleSelection&);
> +    void markMisspellingsAfterMovingParagrah(const VisibleSelection&);

I don't like that these names are tied to paragraph moving since the implementations themselves are generic. How about calling them clearMispellingsAndBadGrammer and markMispellingsAndBadGrammer?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.