[Webkit-unassigned] [Bug 41888] Initial bindings and plumbing for IDBCursor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41888


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org




--- Comment #13 from Adam Barth <abarth at webkit.org>  2010-07-13 13:53:19 PST ---
> It's mostly just boilerplate/build files.  And the only way to land this in chunks is either to land dead code (which we're normally against as a project) or to break chromium in the process (like splitting the WebKit parts into their own patch).
>
> I'm happy to review this as is, so I don't think he should split it up.

Ok.  You'll need fishd to review as well since this touches the WebKit API.

> > WebCore/bindings/scripts/CodeGenerator.pm:480
> >  +      return $name . "_" if exists $cppReservedKeyWords{$name};
> > Yuck
> 
> Really?  Most of the file looks like this.

I mean that we're mangling the IDL names in this magical way.  Maybe a better design would be to add an IDL attribute to explain exactly what's going on?  [ImplementationName=continue_] ?

> > WebCore/storage/IDBCursorImpl.cpp:35
> >  +  class IDBCursorImpl : public IDBCursor {
> > What's the point of hiding the Impl class?
> 
> So that half can run in the Chrome browser process.  This is how all of IndexedDB, LocalStorage, and apparently now WebKit2 works.

Ok.  that wasn't clear to me from the patch, but I'm not an expert on this stuff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.