[Webkit-unassigned] [Bug 41888] Initial bindings and plumbing for IDBCursor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41888


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61392|review?                     |review-
               Flag|                            |




--- Comment #11 from Adam Barth <abarth at webkit.org>  2010-07-13 11:49:27 PST ---
(From update of attachment 61392)
This patch is too large.  Please at least do the WebKit API changes in a separate patch.  Also, consider breaking this patch into even smaller pieces.  Drive-by comments below.

WebCore/GNUmakefile.am:2580
 +    WebCore/storage/IDBCursor.idl \
Bad indent.

WebCore/WebCore.vcproj/WebCore.vcproj:50055
 +        <File
Bad indent.

WebCore/bindings/scripts/CodeGenerator.pm:480
 +      return $name . "_" if exists $cppReservedKeyWords{$name};
Yuck

WebCore/storage/IDBCursor.h:39
 +      // Keep in sync with what's in the .idl file.
Can we assert this at compile time?

WebCore/storage/IDBCursorImpl.cpp:35
 +  class IDBCursorImpl : public IDBCursor {
What's the point of hiding the Impl class?

WebCore/storage/IDBObjectStoreRequest.cpp:115
 +      return request;
request.release()

Please read http://webkit.org/coding/RefPtr.html if you haven't already.

WebKit/chromium/public/WebIDBKeyRange.h:32
 +  namespace WebCore { class IDBKeyRange; }
Please put this on multiple lines so we can add more as needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.