[Webkit-unassigned] [Bug 41888] Initial bindings and plumbing for IDBCursor.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 13 10:38:48 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=41888
--- Comment #8 from Marcus Bulach <bulach at chromium.org> 2010-07-13 10:38:48 PST ---
(In reply to comment #4)
> Looks good, some comments:
>
> > WebCore/GNUmakefile.am
>
> I think you have some tabs there or the indentation is wrong.
done (but I haven't added all the files to all makefiles yet anyway..)
>
> > WebCore/storage/IDBCursorRequest.idl
>
> We don't have that in the spec anymore. I am not sure anymore what we're implementing, though...My suggestion would be to remove this altogether and only add a single IDL file, as per the spec.
as we chatted, I'll do the big cleanup next.
>
> // class IDBCursor
> // ...
> // PassRefPtr<IDBKeyRange> m_keyRange;
>
> You don't want to store a PassRefPtr...make it a RefPtr?
done.
>
> >> PassRefPtr<IDBRequest> request() const;
> >> PassRefPtr<IDBAny> key() const;
> >> PassRefPtr<IDBAny> value() const;
>
> Why do these return PassRefPtr? Do we transfer ownership? If not, can they be raw pointers?
done.
>
> > class WebIDBKeyRange {
> > WebIDBKeyRange(const WebIDBKeyRange& d) { m_private = d.m_private; }
>
> I think you're supposed to use meaningful variable names instead of "d".
done.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list