[Webkit-unassigned] [Bug 41616] [Chromium] DeviceOrientation plumbing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41616





--- Comment #8 from Jeremy Orlow <jorlow at chromium.org>  2010-07-13 07:49:11 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> > (From update of attachment 60534 [details] [details])
> Thanks for the review.
> 
> > WebKit/chromium/src/WebViewImpl.h:44
> >  +  #if ENABLE(DEVICE_ORIENTATION)
> > We shoudl just turn it on now at compile time, but hide it behind a runtime flag.  Then you don't need this stuff.
> Hmm, but we can't turn it on before we have landed an implementation, and we can't land this implementation without the enable guards if the switch is off, so I guess the plan would be to keep them for now and remove them eventually?

I never really had a problem with this in IndexedDB.  I just turned it off via the runtime enabled mechanism.  If you explicitly turn it on and try to use it in javascript, yeah, it'll crash chrome, but that's OK.  Because it can't be accessed without the flag enabled it's fine.

Will that not work for you though?  If so, I'm fine with you putting this stuff in.  It's just that I can't think of many features that have needed it.

> > 
> > WebKit/chromium/src/DeviceOrientationClientImpl.h:40
> >  +  } // namespace WebCore
> > don't need the //
> Will fix. What's the convention for this? Looking at the guidelines, they seem to put a comment like this at the closing of most namespaces, but not in every case?

Cases like these are too obvious to bother with.  Where in the style guideline does it mandate this though?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.