[Webkit-unassigned] [Bug 39588] Provide implementation of DeviceOrientationController and hook into DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39588





--- Comment #18 from Steve Block <steveblock at google.com>  2010-07-13 07:08:55 PST ---
> Hmm, this looks wrong:
Ah, merge error, fixed.

> Is it desirable to cache the orientation, as suggested by
> DeviceOrientationClient::lastOrientation()?
This is required to make sure that new listeners receive an orientation (if available) immediately. The client has no way to know when new listeners are added - it only calls back when new data is available.

> Also, in DeviceOrientationController::addListener(), if m_client is NULL,
> perhaps the controller should take the opportunity to dispatch an event with
> alpha, beta and gamma set to NULL so as to indicate to the web page that no
> orientation data can be provided, rather than doing nothing?
Sure, sounds reasonable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.