[Webkit-unassigned] [Bug 39588] Provide implementation of DeviceOrientationController and hook into DOMWindow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 06:41:02 PDT 2010


--- Comment #16 from hans at chromium.org  2010-07-13 06:41:02 PST ---
(In reply to comment #15)
> Created an attachment (id=61365)
 --> (https://bugs.webkit.org/attachment.cgi?id=61365) [details]
> Patch

Hmm, this looks wrong:

In WebCore/dom/DeviceOrientationController.cpp you add definitions:
+void DeviceOrientation::addListener(DOMWindow* window)
+void DeviceOrientation::removeListener(DOMWindow* window)
+void DeviceOrientation::removeAllListeners(DOMWindow* window)

But they are members of DeviceOrientationController, right?

Is it desirable to cache the orientation, as suggested by DeviceOrientationClient::lastOrientation()? I can see how this would solve the problem of notifying a new observer of the controller that orientation cannot be provided, but worry about the risk of dispatching new events with old orientation data. Not sure whether that is a real problem or not, though.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list