[Webkit-unassigned] [Bug 41925] [Chromium] Linux implementation of <input type=number> UI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 12 22:49:18 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41925





--- Comment #9 from Kent Tamura <tkent at chromium.org>  2010-07-12 22:49:18 PST ---
(In reply to comment #8)
> (From update of attachment 61204 [details])
> WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:90
>  +      paint.setColor(RenderThemeChromiumLinux::saturateAndBrighten(trackHSV, 0, 0));
> code in platform/ should not depend on code in rendering/.
> that's a layering violation.  it seems like you should
> refactor this so that there is another file in platform/chromium/
> that defines the shared theme code.

I see.
Do you think it's acceptable to remain these function in ScrollbarThemeChromiumLinux and call them from RenderThemeChroimiumLinux?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list