[Webkit-unassigned] [Bug 42092] [Chromium] Fix adoptRef usage violation in WebAccessibilityCacheImpl.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 12 22:14:40 PDT 2010


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
                 CC|                            |levin at chromium.org

--- Comment #7 from David Levin <levin at chromium.org>  2010-07-12 22:14:40 PST ---
(In reply to comment #6)
> Created an attachment (id=61321)
 --> (https://bugs.webkit.org/attachment.cgi?id=61321) [details]
> Proposed patch.
> Added use of release(). Can someone commit this for me? The commit bot failed because there was no ChangeLog found. When I run prepareChangeLog it says "No changes found."

If using git, you need to specify the --git-commit and give it an appropriate change like head~1.

If using svn, make sure to run prepareChangeLog from the root of your enlistment so it will see the change.

Regarding Darin's coment about this not being right, I looked over the code, and it does appear to be correct, but I couldn't figure out what that FIXME comment was about. (This does appear to be a leak that is getting fixed.)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list