[Webkit-unassigned] [Bug 41413] [Qt] QtWebKit needs public API for Notifications.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41413





--- Comment #12 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-07-12 17:30:33 PST ---
(From update of attachment 61296)
WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h:113
 +      QWebPage* page(ScriptExecutionContext*);
Is this like a cast? if so call it toPage, that seems to be the standard in WebKit. In Qt we often use that for methods doing for instance conversion.

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.h:196
 +      void cancelRequestsForPermission(QWebFrame* frame, QWebPage::PermissionDomain domain);
Looks OK to me, but I would like to know what Simon thinks, especially about the API part.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.