[Webkit-unassigned] [Bug 40921] WebKit1 and WebKit2 should build as a single DLL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40921


Alice Liu <alice.liu at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61288|review?                     |review+
               Flag|                            |




--- Comment #3 from Alice Liu <alice.liu at apple.com>  2010-07-12 17:15:59 PST ---
(From update of attachment 61288)
> Index: WebKit2/ChangeLog
> ===================================================================
> @@ -1,3 +1,56 @@
> +        * win/WebKit2.def: Added. Copied from WebKit project.
> +        * win/WebKit2.rc: Added resources previously in WebKit.
> +        * win/WebKit2.vcproj: Changed project name to WebKit so we will link output to WebKit.dll.
> +        Removed implementations overlapping with WebKitLib (WebCoreLocalizedStrings, DllMain, WebLocalizableStrings, WebProcessMain).
> +        * win/WebKit2Common.vsprops: Use a framework name of WebKit instead of WebKit2 to reflect project name.
> +        Renamed BUILDING_WEBKIT2 to BUILDING_WEBKIT since there is now just a single WebKit.dll.
> +        * win/WebKit2WebProcess.vcproj: Link against WebKit instead of WebKit2 due to renaming.        

I find it inconsistent that we're building the WebKit2 dll as WebKit.dll, but we're still calling several of these files "WebKit2(.*)".  Could you rename these files without the 2.  follow-up patch is fine with me. 



> Index: WebKit/win/WebKit.vcproj/WebKit.vcproj
> ===================================================================

> -			<File
> -				RelativePath=".\nullplugin.png"
> -				>
> -			</File>

the other pan*.pngs added in WebKit2.vcproj don't seem to be removed from WebKit.vcproj.  

> -			<File
> -				RelativePath=".\searchCancel.png"
> -				>
> -			</File>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.