[Webkit-unassigned] [Bug 42110] Inconsistent Handling of Text Drawing Mode Flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42110





--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2010-07-12 15:06:48 PST ---
I chatted with Dave Hyatt on IRC to get a definitive ruling on this issue.

Dave saw no incorrect code with fill/stroke (in the cross-platform code at least).  Although it is true that the clip gets clobbered in the examples above, nobody even uses clip so we could just yank it.

Fill/stroke are the only values we're even supporting.  When building up the text style enumerations, he was just mapping to the complete cg api, but we (Apple) don't use clip at all, so could simplify things by just getting rid of the unused flags.

I asked if the combination of Fill & Stroke are correct for the cross-platform logic.  Dave checked and confirmed that the combination works fine.... the cross-platform code isn't incorrectly clobbering anywhere that he could see:
* Canvas clobbering the state is fine, since it sets it every time it draws text
* InlineTextBox doesn't clobber and does the right bitwise oring.

I didn't understand why the line in RenderSVGResourceGradient.cpp (line 199) would NOT cause the stroke to get turned off if you were trying to fill and stroke at the same time.

Dave responded that it would, but there's a save/restore.  Text drawing mode is part of the state you save/restore, so nothing is left in an incorrect state.

Bottom line, this is a non-issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.