[Webkit-unassigned] [Bug 41295] [Chromium] Add chromium WebMediaPlayer to PlatformMedia
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 12 13:07:43 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=41295
Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #61257|review? |review-
Flag| |
--- Comment #8 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2010-07-12 13:07:43 PST ---
(From update of attachment 61257)
WebCore/platform/graphics/MediaPlayer.h:78
+ // Using void* instead of WebKit::WebMediaPlayer
this comment introduces WebKit::WebMediaPlayer into WebCore in a
way that the compiler won't even help us notice if we ever rename
WebKit::WebMediaPlayer. that seems bad.
HTMLMediaElement has a reference to a MediaPlayer object. A
MediaPlayer has a MediaPlayerPrivateInterface member as well as
a MediaPlayerClient member, and WebMediaPlayerClientImpl implements
both of those interfaces.
You should be able to static_cast from one of those interfaces to
WebMediaPlayerClientImpl and gets the WebMediaPlayer from there.
This casting can be done at the WebKit/chromium/src level.
BTW, I think you need to invent a WebMediaElement subclass of
WebElement instead of adding a method on WebNode.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list