[Webkit-unassigned] [Bug 27411] [GTK] Clipboard data is lost on exit

Mon Jul 12 07:29:21 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=27411

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61225|review?                     |review-
               Flag|                            |

--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2010-07-12 07:29:21 PST ---
(From update of attachment 61225)
WebKit/gtk/webkit/webkitwebview.cpp:3565
 +                                                        NULL, 0);
Two things: no need to break the line here, in WebKit code we're used to longer lines, and this makes a bit more readable. Also, the style guidelines say we should use 0 instead of NULL (though we do use NULL in a few cases we get warnings otherwise).

As for the content, it looks sane to me, but I'd like to hear mrobinson's opinion as well, since he's the one who's been working on clipboard/dragndrop the most recently (I'll poke him). Also, we might also want to save the PRIMARY clipboard, right? I'll say r- for now, because we need a ChangeLog entry. I assume you are not a committer, so you may want to set commit-queue to ? as well, so that the person who reviews your patch can make the patch be automatic committed for you =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.