[Webkit-unassigned] [Bug 41518] Speech input plumbing in webcore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41518





--- Comment #10 from Jeremy Orlow <jorlow at chromium.org>  2010-07-12 07:21:18 PST ---
(From update of attachment 60744)
steve is probably the best reviewer, but here are some drive by comments


WebCore/page/SpeechInputClientListener.h:14
 +   *     * Neither the name of Google Inc. nor the names of its
use 2 clause

WebCore/page/SpeechInputClient.h:14
 +   *     * Neither the name of Google Inc. nor the names of its
use 2 clause

WebCore/page/SpeechInput.h:14
 +   *     * Neither the name of Google Inc. nor the names of its
use 2 clause

WebCore/Android.mk:383
 +      page/SpeechInput.cpp
need \

WebCore/GNUmakefile.am:2687
 +      WebCore/page/SpeechInputListener.h \
alpha order

WebCore/WebCore.gypi:2034
 +              'page/SpeechInputListener.h',
alpha order

WebCore/WebCore.pro:1605
 +      page/SpeechInputListener.h \
alpha

WebCore/WebCore.vcproj/WebCore.vcproj:22476
 +                  RelativePath="..\page\SpeechInputListener.h"
alpha

WebCore/page/SpeechInput.h:45
 +  
extra new line

WebCore/page/SpeechInput.h:37
 +  #if ENABLE(INPUT_SPEECH)
put includes inside this

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.