[Webkit-unassigned] [Bug 41964] [chromium] popup menu should have the capability of showing labels

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41964


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61115|review?                     |review-
               Flag|                            |




--- Comment #6 from Kent Tamura <tkent at chromium.org>  2010-07-12 03:02:12 PST ---
(From update of attachment 61115)
The code looks OK.  Please fix the build error:

/Users/eseidel/Projects/MacEWS/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/RenderTextControlSingleLine.o
cc1plus: warnings being treated as errors
/Users/eseidel/Projects/MacEWS/WebCore/rendering/RenderTextControlSingleLine.cpp:879: warning: unused parameter 'listIndex'
distcc[99406] ERROR: compile /Users/eseidel/Projects/MacEWS/WebCore/rendering/RenderTextControlSingleLine.cpp on localhost failed


WebCore/platform/chromium/PopupMenuChromium.cpp:73
 +  static const int kTextToLabelPadding = 10;
nit: We don't prepend 'k' prefix to constant value symbols.  This change is ok for consistency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.