[Webkit-unassigned] [Bug 40641] [Qt] Clicking button input does not give it focus

Sun Jul 11 21:13:10 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40641

Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58831|review?                     |review-
               Flag|                            |

--- Comment #4 from Antonio Gomes <tonikitoo at webkit.org>  2010-07-11 21:13:10 PST ---
(From update of attachment 58831)
Hi Viatcheslav. As I said before, patch looks Ok to me. It is a shame that it had to be spun off from bug 22261, where a more general solution was about to take place, but it does not sound as a big deal to me. I look forward for a morecross-port change involving this behavior, but we can make it happen for Qt earlier, yes.

About the patch I'll r- is mainly for two reasons:

- you are adding your own 'log' function. Please use debug function available at LayoutTests/fast/js/resources/js-test-pre.js

- you are adding expected results for Qt only, but not skipping the added test for any other platform (e.g. mac, gtk, chromium). My advice is:

1)  the results should be the same for Qt and Gtk, so please add expected results for Gtk as well, equal to Qt's one;

2) Also make your output such that it is possible to add a general failing result for all other ports where the behavior will remain as is today.
At least for Mac, it seems like the behavior they like to have according to ap: https://bugs.webkit.org/show_bug.cgi?id=22261#c17

The rest of the patch looks fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.