[Webkit-unassigned] [Bug 41607] DeviceOrientationEvent should use optional properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41607





--- Comment #4 from Andreas Kling <andreas.kling at nokia.com>  2010-07-11 16:25:41 PST ---
(From update of attachment 60756)
>WebCore/dom/DeviceOrientation.h:66
> +      bool m_canProvideAlpha;
> +      double m_alpha;
> +      bool m_canProvideBeta;
> +      double m_beta;
> +      bool m_canProvideGamma;
> +      double m_gamma;
This member order will cause unnecessary padding. Better to group the doubles and bools.

Patch looks good otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.