[Webkit-unassigned] [Bug 42021] isEqualNode should work for DocumentType nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42021





--- Comment #3 from Sam Weinig <sam at webkit.org>  2010-07-10 14:27:05 PST ---
(In reply to comment #2)
> (From update of attachment 61143 [details])
> >WebCore/dom/Node.cpp:1795
> > +          NamedNodeMap* othereEntities = documentTypeOther->entities();
> Variable name should be 'otherEntities'
> 
> >WebCore/dom/Node.cpp:1798
> > +          if (entities && entities->mapsEquivalent(othereEntities))
> > +              return false;
> This looks wrong. Shouldn't it be "if (entities && !entities->mapsEquivalent(othereEntities))"?
> 
> Same two comments for the 'notations' section below.

Thanks, I made these changes locally. Unfortunately these two bits are not testable at the moment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.