[Webkit-unassigned] [Bug 41995] Enable binding QObjects to javascript environment for inspector frontend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41995


Andreas Kling <andreas.kling at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61104|review?                     |review-
               Flag|                            |




--- Comment #1 from Andreas Kling <andreas.kling at nokia.com>  2010-07-10 09:30:22 PST ---
(From update of attachment 61104)
First off, every patch needs a ChangeLog entry.
You can use WebKitTools/Scripts/prepare-ChangeLog to generate most of it.

>WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:79
> +          QVariant qvJsObjectMap = property("_q_inspector_js_objects");
Missing #ifndef QT_NO_PROPERTIES

>WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:80
> +          if (qvJsObjectMap.isValid()) {
WebKit normally uses early-return style, so this would be:
if (!qvJsObjectMap.isValid())
    return;

>WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:123
> +       QVariant qvJsObjectMap = inspector->property("_q_inspector_js_objects");
One too many spaces in the indentation here.

r- for missing QT_NO_PROPERTIES check. Change itself looks reasonable to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.