[Webkit-unassigned] [Bug 21680] queryCommandValue("BackColor") returns rgb(0, 0, 0) for elements with transparent background

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21680


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |rniwa at webkit.org
                   |kit.org                     |
  Attachment #61003|0                           |1
        is obsolete|                            |
  Attachment #61087|                            |review?
               Flag|                            |




--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2010-07-09 13:57:57 PST ---
Created an attachment (id=61087)
 --> (https://bugs.webkit.org/attachment.cgi?id=61087)
merged valueStyle in EditorCommand.cpp and Frame::selectionStartStylePropertyValue and added a special case to treat background color

This patch merges valueStyle in EditorCommand.cpp and Frame::selectionStartStylePropertyValue because selectionStartStylePropertyValue was only used in valueStyle.  I added a special case for background color where I check whether the style has transparent background or the current selection is a range.  In either cases, new valueStyle will traverse the tree upwards until it gets a computed style with non-transparent background.  I could improve the change log so give me some feedback please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.