[Webkit-unassigned] [Bug 41925] [Chromium] Linux implementation of <input type=number> UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41925





--- Comment #5 from Tony Chang (Google) <tony at chromium.org>  2010-07-09 12:21:34 PST ---
(From update of attachment 60997)
LGTM (also not a reviewer), just some nits.

WebCore/rendering/RenderThemeChromiumLinux.cpp:187
 +      SkScalar* hsv, SkScalar saturateAmount, SkScalar brightenAmount)
Nit: can we make |hsv| const?

WebCore/rendering/RenderThemeChromiumLinux.cpp:196
 +  SkColor RenderThemeChromiumLinux::outlineColor(SkScalar* hsv1, SkScalar* hsv2)
Nit: Can we make these const too?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.