[Webkit-unassigned] [Bug 41384] Allow Chromium access to Select control choices

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41384


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61066|review?                     |review-
               Flag|                            |




--- Comment #7 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-07-09 11:59:46 PST ---
(From update of attachment 61066)
WebKit/chromium/public/WebOptionElement.h:60
 +      WEBKIT_API bool disabled() const;
hmm... this 'disabled' method seems similar to the inherited
WebFormControlElement::isEnabled?  i see from reading the
implementation that it does a bit more (checks the parent's
disabled state as well).  it seems to me that it would be
better to name this one isEnabled as well.

WebKit/chromium/src/WebSelectElement.cpp:59
 +          items[i] = WebOptionElement(static_cast<HTMLOptionElement*>(sourceItems[i]));
I think you need to check that sourcesItems[i]->hasLocalName(optionTag)
is true before casting to HTMLOptionElement.

I'm basing this on the implementation of HTMLSelectElement::value().
You could also just return a WebVector<WebElement>, and then leave
it up to the consumer to use WebElement::hasTagName.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.