[Webkit-unassigned] [Bug 41971] WebKit2: Add really basic BackForwardList support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 9 11:40:40 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=41971
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-07-09 11:40:40 PST ---
Attachment 61067 did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/WebBackForwardList.cpp:48: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebKit2/UIProcess/WebBackForwardList.cpp:62: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 3 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list