[Webkit-unassigned] [Bug 39624] --squash should go away and become the default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39624


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60408|review?                     |review-
               Flag|                            |




--- Comment #35 from Adam Barth <abarth at webkit.org>  2010-07-09 11:00:57 PST ---
(From update of attachment 60408)
Can we be more user friendly during the transition?  Maybe we should understand --no-squash and print a message that explains the new way is --git-commit=HEAD.. ?  Another option is to automatically re-write --no-squash into --git-commit=HEAD..  Some minor comments below.

WebKitTools/Scripts/webkitpy/tool/steps/checkstyle_unittest.py:38
 +      pass
Should we delete this file if there aren't any tests in it?

WebKitTools/Scripts/webkitpy/tool/steps/commit.py:68
 +              username = User.prompt("%s login: " % e.server_host, repeat=5)
You should use self._tool.user here.

WebKitTools/Scripts/webkitpy/tool/steps/commit.py:71
 +              self._commit(username=username)
What if this throws an AmbiguousCommitError?  I think you want to use some sort of loop with these things as state variables.  You can put a retry limit in the loop if you're worried about going infinite.

WebKitTools/ChangeLog:9
 +          need to be met by a wrapper script around webkit-patch.
This isn't really true anymore, right?  I can use --git-commit=HEAD..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.